Skip to content

[Bookings] Add Yosemite models for booking info #16245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 16, 2025
Merged

[Bookings] Add Yosemite models for booking info #16245

merged 7 commits into from
Oct 16, 2025

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Oct 15, 2025 •
edited by itsmeichigo
Loading

Part of: WOOMOB-1508

Description

This PR updates Yosemite layer to support storing extra info for bookings in the local storage. Changes include:

  • Adds order info property for the readonly Booking model. This will be used for getting extra info to display on booking list items and booking detail screen.
  • Adds new readonly models: BookingOrderInfo, BookingCustomerInfo, BookingPaymentInfo, BookingProductInfo matching the relative Core Data entities added in Bookings: Add new entities for booking info #16242.
  • Updates ReadOnlyConvertible conformance for the models to convert order info for the readonly Booking model.
  • Updates BookingStore to map data from the fetched orders to associated bookings.

In the next PR, the order info will be populated on the UI.

Testing steps

The new data is not used yet so just CI passing is sufficient.

Testing information

Added tests to confirm the new mapping logic.

Screenshots

N/A

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.5 milestone Oct 15, 2025
@RafaelKayumov RafaelKayumov added the type: task An internally driven task. label Oct 15, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 15, 2025 •
edited
Loading

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is assigned to the milestone 23.5. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 15, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16245-086b94f
Version23.4
Bundle IDcom.automattic.alpha.woocommerce
Commit086b94f
Installation URL0qa2f1jd6cj08
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo marked this pull request as ready for review October 16, 2025 03:11
@itsmeichigo itsmeichigo requested a review from adborbas October 16, 2025 03:11
adborbas
adborbas reviewed Oct 16, 2025
View reviewed changes
Modules/Sources/Yosemite/Model/Booking/BookingProductInfo+ReadOnlyConvertible.swift
import Foundation
import Storage

// MARK: - Storage.BookingProductInfo: ReadOnlyConvertible
Copy link
Contributor

@adborbas adborbas Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering what these MARK notations do at the extensions? Are they used for code generation or something?

Copy link
Contributor

@itsmeichigo itsmeichigo Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just for clarity I believe.

adborbas
adborbas approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@adborbas adborbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@itsmeichigo itsmeichigo merged commit 061882d into trunk Oct 16, 2025
13 checks passed
@itsmeichigo itsmeichigo deleted the WOOMOB-1508-add-yosemite-models-for-bookings-info branch October 16, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmeichigo itsmeichigo itsmeichigo left review comments

@adborbas adborbas adborbas approved these changes

Assignees

No one assigned

Labels

type: task An internally driven task.

Projects

None yet

Milestone

23.5

Development

Successfully merging this pull request may close these issues.

6 participants

@RafaelKayumov @dangermattic @wpmobilebot @itsmeichigo @adborbas